Re: Removal of duplicate variable declarations in fe-connect.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Removal of duplicate variable declarations in fe-connect.c
Date: 2019-02-22 04:22:46
Message-ID: 20190222042246.GA24416@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 22, 2019 at 11:33:17AM +1100, Haribabu Kommi wrote:
> During the development of another feature, I found that same local
> variables are declared twice.
> IMO, there is no need of again declaring the local variables. Patch
> attached.

Indeed, fixed. That's not a good practice, and each variable is
assigned in its own block before getting used, so there is no
overlap.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-02-22 04:31:09 Re: Using old master as new replica after clean switchover
Previous Message Bruce Momjian 2019-02-22 03:58:16 Unified security key managment