On Thu, Feb 14, 2019 at 03:07:56PM +0100, Michael Banck wrote:
> This also revealed a second bug in the pg_basebackup test suite where
> the offset for the corruption in the second file was wrong, so it
> actually never got corrupted, and the tests only passed due to the above
> twice than expected number of written bytes. The write() probably
> overflowed into an adjacent block so that the total number of corrupted
> blocks was as expected by accident. Oops, my bad, patch attached.
Fixed and back-patched where adapted, thanks! ee9e145 was a first
shot for a fix in pg_basebackup tests, but it has missed one seek()
call.
--
Michael