Re: [Suspect SPAM] Better error messages when lacking connection slots for autovacuum workers and bgworkers

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [Suspect SPAM] Better error messages when lacking connection slots for autovacuum workers and bgworkers
Date: 2019-02-14 23:08:54
Message-ID: 20190214230854.GB2240@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 14, 2019 at 09:04:37PM +0900, Kyotaro HORIGUCHI wrote:
> I agree to the distinctive messages, but the autovaccum and
> bgworker cases are in a kind of internal error, and they are not
> "connection"s. I feel that elog is more suitable for them.

I used ereport() for consistency with the existing code, still you are
right that we ought to use elog() as this is the case of a problem
which should not happen.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-02-14 23:15:24 Re: pg_basebackup ignores the existing data directory permissions
Previous Message Michael Paquier 2019-02-14 23:06:16 Re: [PATCH] xlogreader: do not read a file block twice