Re: pgsql: Use Getopt::Long for catalog scripts

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org, John Naylor <jcnaylor(at)gmail(dot)com>
Subject: Re: pgsql: Use Getopt::Long for catalog scripts
Date: 2019-02-12 21:32:25
Message-ID: 20190212213225.GA11073@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2019-Feb-13, Thomas Munro wrote:

> whelk, woodlouse and dory say:
>
> Generating src/interfaces/ecpg/pgtypeslib/pgtypeslib.def...
> Unknown option: i../../../src/include/
> Usage: perl -I [directory of Catalog.pm] Gen_fmgrtab.pl
> [--include-path/-i <path>] [path to pg_proc.dat]
>
> Options:
> --output Output directory (default '.')
> --include-path Include path in source tree
>
> Does Solution.pm need to be tweaked?

So Getopt::Long does not like the missing ' ' or '=', eh?
I pushed an untested fix, let's see if that's it. Thanks for the poke.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2019-02-12 21:59:25 pgsql: Relax overly strict assertion
Previous Message Alvaro Herrera 2019-02-12 21:31:21 pgsql: Blind attempt at fixing Windows build