| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Lakhin <a(dot)lakhin(at)postgrespro(dot)ru> |
| Subject: | Re: Too rigorous assert in reorderbuffer.c |
| Date: | 2019-02-12 13:53:43 |
| Message-ID: | 20190212135343.GA29518@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Feb-11, Alvaro Herrera wrote:
> On 2019-Feb-07, Arseny Sher wrote:
>
> > Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>
> > > Ah, okay. Does the test still fail when run without the code fix?
> >
> > Yes. The problem here is overriding cmax of catalog (pg_attribute in the
> > test) tuples, so it fails without any data at all.
>
> Makes sense.
>
> I thought the blanket removal of the assert() was excessive, and we can
> relax it instead; what do you think of the attached?
More precisely, my question was: with this change, does the code still
work correctly in your non-toy case?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ramanarayana | 2019-02-12 13:54:20 | Re: BUG #15548: Unaccent does not remove combining diacritical characters |
| Previous Message | Sergei Kornilov | 2019-02-12 13:51:57 | Re: Planning counters in pg_stat_statements (using pgss_store) |