Re: pgsql: Allow some recovery parameters to be changed with reload

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow some recovery parameters to be changed with reload
Date: 2019-02-09 18:35:52
Message-ID: 20190209183552.GL6197@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Greetings,

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > On 2019-Feb-08, Michael Paquier wrote:
> >> The timestamp of this commit is a bit messed up:
> >> commit: 13b89f96d07ad3da67b57f66c134c3609bd3e98f
> >> author: Peter Eisentraut <peter(at)eisentraut(dot)org>
> >> date: Mon, 4 Feb 2019 09:28:17 +0100
> >> committer: Peter Eisentraut <peter(at)eisentraut(dot)org>
> >> date: Thu, 7 Feb 2019 08:34:48 +0100
> >>
> >> Perhaps you overlooked a --reset-author switch?
>
> > I don't think we actually have a rule about these timestamps, and I
> > don't think we really care, do we?
>
> Yeah, if you want to see a sequence of dates that makes sense,
> you need to look at the commit-date. Whether the author-date
> closely matches that depends on the particular committer's
> workflow.

While I agree that we don't really have a formal policy, there are
certainly some who do (or, at least did) seem to care quite a bit about
this and that's why I've been using '--ignore-date' for quite some time
in my workflow:

https://www.postgresql.org/message-id/CA%2BTgmobEgs1%3DAT0_SRvf6K9XrG7QAUyRNeuv5D9oaXrmpST9fw%40mail.gmail.com

Thanks!

Stephen

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-02-09 22:30:48 pgsql: Refactor the representation of indexable clauses in IndexPaths.
Previous Message Tom Lane 2019-02-09 16:41:24 pgsql: Call set_rel_pathlist_hook before generate_gather_paths, not aft