Re: pgsql: Fix included file path for modern perl

From: Andres Freund <andres(at)anarazel(dot)de>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix included file path for modern perl
Date: 2019-02-06 09:27:15
Message-ID: 20190206092715.7mpswmfx2znvu6bq@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2019-02-06 00:36:07 +0000, Andrew Dunstan wrote:
> Fix included file path for modern perl
>
> Contrary to the comment on 772d4b76, only paths starting with "./" or
> "../" are considered relative to the current working directory by perl's
> "do" function. So this patch converts all the relevant cases to use "./"
> paths. This only affects MSVC.
>
> Backpatch to all live branches.

Hm, is it possible this broke
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2019-02-06%2002%3A41%3A15
and
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dory&dt=2019-02-06%2000%3A45%3A25
both report something like
Use of uninitialized value in multiplication (*) at src/tools/msvc/Solution.pm line 181, <$i> line 783.
Use of uninitialized value in division (/) at src/tools/msvc/Solution.pm line 184, <$i> line 783.
Illegal division by zero at src/tools/msvc/Solution.pm line 184, <$i> line 783.

starting with this commit.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2019-02-06 10:55:12 Re: pgsql: Fix included file path for modern perl
Previous Message Andres Freund 2019-02-06 09:17:09 pgsql: Fix heap_getattr() handling of fast defaults.