From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Synchronize with imath upstream |
Date: | 2019-02-03 06:20:48 |
Message-ID: | 20190203062048.GB6226@rfd.leadboat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Feb 03, 2019 at 06:01:51AM +0000, Andrew Gierth wrote:
> >>>>> "Noah" == Noah Misch <noah(at)leadboat(dot)com> writes:
>
> Noah> If the compiler supports -Wdeclaration-after-statement, I add
> Noah> -Wno-declaration-after-statement for imath.c.
>
> I found it much simpler to strip out -Wdeclaration-after-statement
> instead:
>
> $(RYU_OBJS): override CFLAGS := $(filter-out -Wdeclaration-after-statement,$(CFLAGS))
The -Wno-declaration-after-statement approach takes eight lines of code, and
the filter-out approach takes one. On the other hand, using $(filter-out)
changes any runs of whitespace to single spaces ("$(filter-out foo,a b c)"
yields "a b c"). We do risk that with CPPFLAGS and LDFLAGS in a few places.
I don't want to proliferate that practice, because it changes semantics of
CFLAGS containing -DFOO="arbitrary text".
From | Date | Subject | |
---|---|---|---|
Next Message | rajan | 2019-02-03 07:06:23 | Re: Able to do ALTER DEFAULT PRIVILEGES from a user who is not the owner |
Previous Message | Andrew Gierth | 2019-02-03 06:01:51 | Re: Synchronize with imath upstream |