| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Дилян Палаузов <dpa-postgres(at)aegee(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: psql and readline comments |
| Date: | 2019-01-29 23:02:14 |
| Message-ID: | 20190129230214.GD25187@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Jan 29, 2019 at 04:59:40AM +0000, Andrew Gierth wrote:
> >>>>> "Bruce" == Bruce Momjian <bruce(at)momjian(dot)us> writes:
>
> Bruce> Uh, bind as a key? Does the patch have any effect then?
>
> As I said, libedit does not bind M-# by default, and has no equivalent
> to readline's comment-begin variable. I have no idea what the patch
> would do when linked against libedit without actually trying it out
> (which I have not done).
>
> Bruce> If not, maybe we should just do this for libreadline.
>
> Bear in mind that for licensing reasons, some package builds build psql
> against libedit but then wedge readline in at runtime using LD_PRELOAD.
> So doing things differently at compile time based on whether it's
> libedit or readline will not work well with that.
Seems like adding this would be more trouble than it is worth then.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2019-01-29 23:48:27 | Re: BUG #15610: Performance problem of PostgreSQL 11.1 Windows version (EDB created version) |
| Previous Message | Saul, Jean Paolo | 2019-01-29 22:05:02 | Re: BUG #15609: synchronous_commit=off insert performance regression with secondary indexes |