Re: psql and readline comments

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Дилян Палаузов <dpa-postgres(at)aegee(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: psql and readline comments
Date: 2019-01-28 19:17:31
Message-ID: 20190128191731.GC26761@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sat, Jan 26, 2019 at 04:41:17AM +0000, Andrew Gierth wrote:
> >>>>> "Bruce" == Bruce Momjian <bruce(at)momjian(dot)us> writes:
>
> Bruce> Agreed. I am not sure how someone would conditionally bind M-#
> Bruce> to -- _only_ in psql,
>
> By doing this in .inputrc:
>
> $if psql
> set comment-begin "--"
> $endif
>
> (observe that we set rl_readline_name in order to allow this)
>
> But that shouldn't necessarily stop us doing the setting in psql by
> default - it just needs to be verified that it does compile against the
> libedit versions people are actually using, and not break anything. (On
> the libedit on my system, rl_variable_bind ends up trying to bind the
> variable as a _key_, and I have no idea what effect that would have if
> any. Note that libedit does not seem to bind M-# by default.)

Uh, bind as a key? Does the patch have any effect then? If not, maybe
we should just do this for libreadline.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Hugh Ranalli 2019-01-28 20:26:12 Re: BUG #15548: Unaccent does not remove combining diacritical characters
Previous Message Vijaykumar Jain 2019-01-28 11:08:31 Re: [External] Facing error frequently on tomcat app server