Re: pg_stat_ssl additions

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: peter(dot)eisentraut(at)2ndquadrant(dot)com
Cc: LouPicciano(at)comcast(dot)net, tgl(at)sss(dot)pgh(dot)pa(dot)us, bruce(at)momjian(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_stat_ssl additions
Date: 2019-01-28 08:14:00
Message-ID: 20190128.171400.111796002.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello, thank you for the new version.

At Fri, 4 Jan 2019 00:25:57 +0100, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote in <3f8a7a73-cebe-016f-49e3-853733f8baf2(at)2ndquadrant(dot)com>
> Updated patches for some merge conflicts

0001: Seems perfect to me.

0002:

The test 54-56 of 001_ssltest.pl failed, which succeeded before
applying 0002. Seems to need to use another user.

# Failed test 'pg_stat_ssl view without client certificate: no stderr'
# at t/001_ssltests.pl line 313.
# got: 'psql: SSL error: certificate verify failed
# FATAL: no pg_hba.conf entry for host "127.0.0.1", user "ssltestuser", database "trustdb", SSL off
# '

If this is not specific to my environment, the connevcion string
at line 313 of 001_ssltests.pl needs sslrootcert setting (, which
is feeded to test_connect_ok/fails() via $connstr, not via
$common_connstr).

0003: Looks fine to me.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2019-01-28 08:19:02 Re: pg_stat_ssl additions
Previous Message Magnus Hagander 2019-01-28 08:05:26 Re: pg_basebackup, walreceiver and wal_sender_timeout