Old protocol fastpath calls borked?

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Old protocol fastpath calls borked?
Date: 2019-01-24 21:50:32
Message-ID: 20190124215032.wnzx5pw3gyxfusgr@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

In parse_fcall_arguments_20():

c0a8c3ac13f8 (Tom Lane 2003-05-08 18:16:37 +0000 579) argsize = pq_getmsgint(msgBuf, 4);
0ac6298bb8ac (Tom Lane 2003-05-09 18:08:48 +0000 580) if (argsize == -1)
0ac6298bb8ac (Tom Lane 2003-05-09 18:08:48 +0000 581) {
0ac6298bb8ac (Tom Lane 2003-05-09 18:08:48 +0000 582) fcinfo->argnull[i] = true;
147d4bf3e5e3 (Tom Lane 2006-04-04 19:35:37 +0000 583) fcinfo->arg[i] = OidReceiveFunctionCall(typreceive, NULL,
147d4bf3e5e3 (Tom Lane 2006-04-04 19:35:37 +0000 584) typioparam, -1);
0ac6298bb8ac (Tom Lane 2003-05-09 18:08:48 +0000 585) continue;
c0a8c3ac13f8 (Tom Lane 2003-05-08 18:16:37 +0000 586) }

we appear to constantly setting argnull to true for all arguments? Since,
apparently, 2003? I don't have a test-program at hand, but that kind of seems
to suggest this never really has been used?

Greetings,

Andres Freund

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-01-24 22:04:32 Re: Old protocol fastpath calls borked?
Previous Message Tomas Vondra 2019-01-24 21:42:55 Re: Delay locking partitions during INSERT and UPDATE