| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Christoph Berg <myon(at)debian(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Surjective functional indexes |
| Date: | 2019-01-15 00:00:37 |
| Message-ID: | 20190115000037.zl26h3z43mxi73sr@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-01-14 18:55:18 -0500, Stephen Frost wrote:
> * Andres Freund (andres(at)anarazel(dot)de) wrote:
> > > Or are you suggesting that pg_dump in v12+ would throw errors if it
> > > finds that set? Or that we'll dump it, but fail to allow it into a
> > > v12+ database? What if v12 sees "recheck_on_update='false'", as a v11
> > > pg_dump might output today?
> >
> > It'll just error out on restore (including the internal one by
> > pg_upgrade). I don't see much point in doing more, this isn't a widely
> > used option by any stretch.
>
> This.. doesn't actually make sense. The pg_upgrade will use v12+
> pg_dump. You're saying that the v12+ pg_dump will dump out the option,
> but then the restore will fail to understand it?
Why does that not make sense? With one exception the reloptions code in
pg_dump doesn't have knowledge of individual reloptions. So without
adding any special case code pg_dump will just continue to dump the
option. And the server will just refuse to restore it, because it
doesn't know it anymore.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-01-15 00:03:10 | Re: [HACKERS] Surjective functional indexes |
| Previous Message | Stephen Frost | 2019-01-14 23:58:23 | Re: [HACKERS] Surjective functional indexes |