From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: emacs configuration for new perltidy settings |
Date: | 2019-01-09 01:44:30 |
Message-ID: | 20190109014430.GB3738862@rfd.leadboat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 08, 2019 at 08:17:43AM -0500, Andrew Dunstan wrote:
> On 1/3/19 12:53 AM, Noah Misch wrote:
> > If I run perltidy on 60d9979, then run perl-mode indent, the diff between the
> > perltidy run and perl-mode indent run is:
> > 129 files changed, 8468 insertions(+), 8468 deletions(-)
> > If I add (perl-continued-brace-offset . -2):
> > 119 files changed, 3515 insertions(+), 3515 deletions(-)
> > If I add (perl-indent-continued-arguments . 4) as well:
> > 86 files changed, 2626 insertions(+), 2626 deletions(-)
> > If I add (perl-indent-parens-as-block . t) as well:
> > 65 files changed, 2373 insertions(+), 2373 deletions(-)
> Sounds good. What do the remaining diffs look like?
I've attached them. Most involve statement continuation in some form. For
example, src/backend/utils/mb/Unicode has numerous instances where perl-mode
indents hashref-constructor curly braces as though they were code blocks.
Other diff lines involve labels. Others are in string literals.
Attachment | Content-Type | Size |
---|---|---|
perltidy-to-perl-mode-indent.diff | text/plain | 263.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Imai, Yoshikazu | 2019-01-09 02:08:50 | RE: speeding up planning with partitions |
Previous Message | Michael Paquier | 2019-01-09 01:37:56 | Re: Offline enabling/disabling of data checksums |