Re: Remove Deprecated Exclusive Backup Mode

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove Deprecated Exclusive Backup Mode
Date: 2019-01-05 18:16:06
Message-ID: 20190105181605.GM2528@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Laurenz Albe (laurenz(dot)albe(at)cybertec(dot)at) wrote:
> I too only learned about this recently, while the problem with exclusive
> backups has been known at least since 2008 (c979a1fe), and nobody felt
> this to be a terrible problem back then.

My recollection was that back then it wasn't clear what to *do* about
the problem. Once we had a solution (non-exclusive backups) we
deprecated the exclusive backup mechanism.

> I believe that the danger is greatly overrated. It is not like you end
> up with a corrupted database after a crash, and you get a pretty helpful
> error message. Many people are happy enough to live with that.

Unfortunately, people get corrupted databases all the time because the
backups are corrupted. The problem with databases not restarting
correctly is another issue with the exclusive backup method but it's
certainly not the only one.

> I'm on board with deprecating and removing it eventually, but I see no
> problem in waiting for the customary 5 years.

We don't actually have a 'customary 5 years' rule of any sort.

> And yes, a prominent warning in the next major release notes would be
> a good thing.

This is two years too late, at best. That is, maybe it would have made
sense to highlight that the exclusive backup method was deprecated when
it was made so, but that ship has sailed. Further, we don't put out
announcements saying "we're going to remove X in the next release" and I
don't see it making sense to start now.

Thanks!

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2019-01-05 18:19:20 Re: Remove Deprecated Exclusive Backup Mode
Previous Message Peter Geoghegan 2019-01-05 17:41:37 Re: btree.sgml typo?