| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Logical decoding for operations on zheap tables |
| Date: | 2019-01-03 18:13:42 |
| Message-ID: | 201901031813.spi5pznj2b67@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Jan-03, Andres Freund wrote:
> > Apart from this, we need to define different decode functions for
> > zheap operations as the WAL data is different for heap and zheap, so
> > same functions can't be used to decode.
>
> I'm very strongly opposed to that. We shouldn't have expose every
> possible storage method to output plugins, that'll make extensibility
> a farce. I think we'll either have to re-form a HeapTuple or decide
> to bite the bullet and start exposing tuples via slots.
Hmm, without looking at the patches, I agree that the tuples should be
given as slots to the logical decoding interface. I wonder if we need a
further function in the TTS interface to help decoding, or is the
"getattr" stuff sufficient.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-01-03 18:19:58 | Re: BUG #15548: Unaccent does not remove combining diacritical characters |
| Previous Message | Andres Freund | 2019-01-03 18:03:15 | Re: Unified logging system for command-line programs |