| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | John Naylor <jcnaylor(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: reducing the footprint of ScanKeyword (was Re: Large writable variables) |
| Date: | 2018-12-31 01:48:01 |
| Message-ID: | 20181231014801.lse3vb5mat4agiid@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2018-12-29 16:59:52 -0500, John Naylor wrote:
> I think 0001 with complete keyword lookup replacement is in decent
> enough shape to post. Make check-world passes. A few notes and
> caveats:
I tried to take this for a spin, an for me the build fails because various
frontend programs don't have KeywordOffsets/Strings defined, but reference it
through various functions exposed to the frontend (like fmtId()). That I see
that error but you don't is probably related to me using -fuse-ld=gold in
CFLAGS.
I can "fix" this by including kwlist_d.h in common/keywords.c
regardless of FRONTEND. That also lead me to discover that the build
dependencies somewhere aren't correctly set-up, because I need to
force a clean rebuild to trigger the problem again, just changing
keywords.c back doesn't trigger the problem.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chapman Flack | 2018-12-31 02:15:19 | Re: PostgreSQL vs SQL/XML Standards |
| Previous Message | Michael Paquier | 2018-12-31 01:20:28 | Re: Removing --disable-strong-random from the code |