| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: removal of dangling temp tables |
| Date: | 2018-12-28 16:23:58 |
| Message-ID: | 201812281623.qlyp5nygu3pt@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-Dec-28, Alvaro Herrera wrote:
> On 2018-Dec-28, Michael Paquier wrote:
>
> > On Fri, Dec 28, 2018 at 12:05:34AM -0300, Alvaro Herrera wrote:
> > > The server code allocates arrays, but that's fine because that code is
> > > recompiled. Extensions only pass pointers around -- they don't create
> > > any additional arrays.
> >
> > There are many exotic extensions which could be using sizeof(PGPROC)
> > as that's a popular structure,
>
> Can you show one instance of this?
I looked at
https://github.com/postgrespro/pg_wait_sampling/blob/master/pg_wait_sampling.c
https://github.com/citusdata/citus/search?q=pgproc&unscoped_q=pgproc
and skimmed a few others can't find any instance where the full struct
is used, as opposed to just a pointer to it.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-12-28 16:35:39 | Re: removal of dangling temp tables |
| Previous Message | Fabien COELHO | 2018-12-28 15:46:10 | Re: pg_dump multi VALUES INSERT |