| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>, chenhj <chjischj(at)163(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Connections hang indefinitely while taking a gin index's LWLock buffer_content lock |
| Date: | 2018-12-14 16:19:27 |
| Message-ID: | 20181214161927.GA8349@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 13, 2018 at 10:40:59PM +0300, Alexander Korotkov wrote:
> On Thu, Dec 13, 2018 at 8:06 PM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> > That's the same variable, one place is definition while other is potential misuse.
> > Seems like these 2 lines [0]
> >
> > + if (BufferIsValid(lbuffer))
> > + UnlockReleaseBuffer(lbuffer);
> >
> > are superfluous: lbuffer is UnlockReleased earlier.
>
> Thanks to everybody for noticing! Speaking more generally backpatch
> to 9.4 was completely wrong: there were multiple errors. It's my
> oversight, I forget how much better our xlog system became since 9.4
> :)
>
> I've pushed bf0e5a73be fixing that.
I can confirm the compiler warning is now gone. Thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-12-14 16:28:43 | removal of dangling temp tables |
| Previous Message | Tom Lane | 2018-12-14 15:58:15 | Re: valgrind issues on Fedora 28 |