| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "simon(at)2ndquadrant(dot)com" <simon(at)2ndquadrant(dot)com>, "ams(at)2ndquadrant(dot)com" <ams(at)2ndquadrant(dot)com>, "masao(dot)fujii(at)gmail(dot)com" <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | Re: Making WAL receiver startup rely on GUC context for primary_conninfo and primary_slot_name |
| Date: | 2018-12-14 12:18:26 |
| Message-ID: | 20181214121826.GA5012@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 14, 2018 at 12:23:09PM +0300, Sergei Kornilov wrote:
> Not sure i can be reviewer since this was initially my proposal.
No issues from me if you wish to review the code. In my opinion, it is
not a problem if you are a reviewer as I wrote the code.
> I vote +1 for this patch. Code looks good and i think we have no
> reason to leave RequestXLogStreaming as-is.
Thanks for the input. The take on my side is to be able to remove
ready_to_display from WalRcv so let's see what others think.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2018-12-14 12:29:20 | Re: explain plans with information about (modified) gucs |
| Previous Message | Matsumura, Ryo | 2018-12-14 12:16:27 | RE: [PROPOSAL]a new data type 'bytea' for ECPG |