Re: Ryu floating point output patch

From: Andres Freund <andres(at)anarazel(dot)de>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Ryu floating point output patch
Date: 2018-12-13 21:00:12
Message-ID: 20181213210012.i7iihamlbi7vfdiw@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2018-12-13 20:53:23 +0000, Andrew Gierth wrote:
> >>>>> "Andres" == Andres Freund <andres(at)anarazel(dot)de> writes:
>
> >> This code in particular was very heavily into using mixed
> >> declarations and code throughout. Removing those was moderately
> >> painful.
>
> Andres> I wonder if we should instead relax those restriction for the
> Andres> largely foreign pieces of code?
>
> Do we have any reason for the restriction beyond stylistic preference?

No. Robert and Tom were against allowing mixing declarations and code, a
few more against // comments. I don't quite agree with either, but
getting to the rest of C99 seemed more important than fighting those out
at that moment.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2018-12-13 21:01:22 Re: Ryu floating point output patch
Previous Message Andrew Gierth 2018-12-13 20:53:23 Re: Ryu floating point output patch