| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: pg_partition_tree crashes for a non-defined relation |
| Date: | 2018-12-07 23:05:40 |
| Message-ID: | 20181207230540.GA12740@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 07, 2018 at 10:04:06AM +0900, Michael Paquier wrote:
> While testing another patch, I have bumped into the issue of
> $subject... I should have put some more negative testing from the start
> on this stuff, here is a culprit query when passing directly an OID:
> select pg_partition_tree(0);
>
> I think that we should make the function return NULL if the relation
> defined does not exist, as we usually do for system-facing functions.
> It is also easier for the caller to know that the relation does not
> exist instead of having a plpgsql try/catch wrapper or such.
>
> Thoughts?
Are there any objections about fixing this issue? I would rather fix it
sonner than later.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2018-12-07 23:22:12 | Re: Thinking about EXPLAIN ALTER TABLE |
| Previous Message | Tom Lane | 2018-12-07 22:04:32 | Re: slow queries over information schema.tables |