From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Pavel Raiskup <praiskup(at)redhat(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: minor leaks in pg_dump (PG tarball 10.6) |
Date: | 2018-12-06 16:13:12 |
Message-ID: | 20181206161312.GN3415@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Greetings,
* Pavel Raiskup (praiskup(at)redhat(dot)com) wrote:
> On Wednesday, December 5, 2018 4:59:18 PM CET Stephen Frost wrote:
> > This change doesn't seem to make any sense to me..? If anything, seems
> > like we'd end up overallocating memory *after* this change, where we
> > don't today (though an analyzer tool might complain because we don't
> > free the memory from it and instead copy the pointer from each of these
> > items into the tbinfo structure).
>
> Correct, I haven't think that one through. I was confused that some items
> related to the dropped columns could be unreferenced. But those are
> anyways allocated as a solid block with others (not intended to be ever
> free()'d). Feel free to ignore that.
Right.
I've pushed the other changes.
Thanks!
Stephen
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2018-12-06 16:19:00 | Re: slow queries over information schema.tables |
Previous Message | Stephen Frost | 2018-12-06 16:07:00 | Re: Minor typo |