Re: Use durable_unlink for .ready and .done files for WAL segment removal

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: bossartn(at)amazon(dot)com
Cc: michael(at)paquier(dot)xyz, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Use durable_unlink for .ready and .done files for WAL segment removal
Date: 2018-12-06 04:55:46
Message-ID: 20181206.135546.16142622.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello.

At Wed, 5 Dec 2018 16:11:23 +0000, "Bossart, Nathan" <bossartn(at)amazon(dot)com> wrote in <DB47EBD7-7291-4C39-9F8F-BE42E5193BD5(at)amazon(dot)com>
> The v4 patch looks good to me!

durable_unlnk has two modes of faiure. Failure to unlink and
fsync. If once it fails at the fsync stage, subsequent
durable_unlink calls for the same file always fail to unlink with
ENOENT. If durable_unlink is intended to be called repeatedly on
falure, perhaps it should return a different code for each
failure so that the caller can indentify what to do next.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-12-06 05:00:22 Re: Query with high planning time at version 11.1 compared versions 10.5 and 11.0
Previous Message Amit Langote 2018-12-06 04:50:39 Re: Query with high planning time at version 11.1 compared versions 10.5 and 11.0