Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

Hi,

On 2018-12-01 17:28:54 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2018-12-01 12:06:36 -0500, Tom Lane wrote:
> >> Or should we go so far as to have configure add -msse2 automatically?
>
> > Probably not - there's several OSs / distributions that do not yet
> > require an SSE2 capable CPU. While I personally don't care much about
> > such machines, I don't think it's worth desupportem them as long as
> > mainstream compilers with -fexcess-precision=standard exist.
>
> I guess I wasn't precise enough: I meant add -msse2 if on x86 and
> compiler doesn't take -fexcess-precision=standard.

Hm, I still don't like that: It'd silently bump the minimum required
architecture. Like in the case of x86-32 freebsd, which doesn't require
sse2 and uses clang, the maintainer wouldn't notice that they would have
to switch to gcc to continue supporting their baseline.

It's not like there's that many people compiling for such platforms with
insufficient compiler support, so forcing them to specify -msse2 if
that's the desired escape hatch doesn't sound terrible to me.

Greetings,

Andres Freund