Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Bug fix for glibc broke freebsd build in REL_11_STABLE
Date: 2018-12-01 21:20:56
Message-ID: 20181201212056.ubuj42qh6lrwqy4u@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,m

On 2018-12-01 12:06:36 -0500, Tom Lane wrote:
> I wonder whether we shouldn't remove the clang aspect of the test
> you added, ie just make it read "if on x86, you must have either
> -fexcess-precision=standard or -msse2".

That sounds reasonable.

> Or should we go so far as to have configure add -msse2 automatically?

Probably not - there's several OSs / distributions that do not yet
require an SSE2 capable CPU. While I personally don't care much about
such machines, I don't think it's worth desupportem them as long as
mainstream compilers with -fexcess-precision=standard exist.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sergei Agalakov 2018-12-01 22:13:01 {PROPOSAL] add session information column to pg_stat_statements
Previous Message Sergei Kornilov 2018-12-01 21:13:27 Re: Frontends including fd.h