| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Switch pg_verify_checksums back to a blacklist |
| Date: | 2018-11-30 23:00:16 |
| Message-ID: | 20181130230016.GA1846@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Nov 30, 2018 at 02:18:18PM -0500, Andrew Dunstan wrote:
> All it actually needs is this additional line after the mkdir:
>
> $tablespace_dir = TestLib::real_dir($tablespace_dir);
>
> Explanation: TAP tests on msys need to run with the DTK perl, which
> understands msys virtualized paths. Postgres, however, does not understand
> such paths, so before you use such a value in, say, CREATE TABLESPACE, you
> need to translate it into a path on the underlying file system.
Thanks Andrew for confirming. I have committed your suggestion, which
should calm down jacana.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-30 23:08:04 | Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot |
| Previous Message | Michael Paquier | 2018-11-30 22:59:14 | pgsql: Fix tablespace path TAP test of pg_verify_checksums for msys |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2018-11-30 23:01:01 | Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk |
| Previous Message | Dmitry Dolgov | 2018-11-30 22:57:21 | Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead |