Re: idle-in-transaction timeout error does not give a hint

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: ishii(at)sraoss(dot)co(dot)jp
Cc: ideriha(dot)takeshi(at)jp(dot)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: idle-in-transaction timeout error does not give a hint
Date: 2018-11-30 07:05:54
Message-ID: 20181130.160554.260828098.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello.

At Thu, 29 Nov 2018 09:16:01 +0900 (JST), Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote in <20181129(dot)091601(dot)830026250066724330(dot)t-ishii(at)sraoss(dot)co(dot)jp>
> >>> Hi, it makes sense to me. One can submit transaction again same as
> >>> other cases you mentioned.
> >>>
> >>> I didn't attach the patch but according to my simple experiment in
> >>> psql the output would become the following:
> >>>
> >>> FATAL: terminating connection due to idle-in-transaction timeout
> >>> HINT: In a moment you should be able to reconnect to the
> >>> database and repeat your command.
> >>
> >>Alternative HINT message would be something like:
> >>
> >>HINT: In a moment you should be able to reconnect to the
> >> database and restart your transaction.
> >>
> >>This could make the meaning of the error (transaction aborted) cleaner and might give
> >>a better suggestion to the user.
> >
> > Agreed. Changing "command" to "transaction" seems more accurate. People might think
> > only the command they hit is not sent but transaction is still alive though it's of course unnatural
> > that transaction is alive after connection is terminated.

"session" seems more correct and covers both (and the other
instances below).

> > In this case you could change the comment issued by other errors mentioned while you're at it.
> >
> > Regards,
> > Takeshi Ideriha
>
> I have added this to the next CF (2019-01).

I found several more instances.

"terminating connection due to conflict with recovery" (3 places)
"terminating connection due to administrator command" (1 place)

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kato, Sho 2018-11-30 07:15:00 RE: Planning time of Generic plan for a table partitioned into a lot
Previous Message David Rowley 2018-11-30 06:57:09 Re: Planning time of Generic plan for a table partitioned into a lot