| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, sk(at)zsrv(dot)org, vik(dot)fearing(at)2ndquadrant(dot)com, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Dave Page <dpage(at)pgadmin(dot)org> |
| Subject: | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |
| Date: | 2018-11-29 05:56:08 |
| Message-ID: | 20181129055608.GA2356@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 29, 2018 at 09:09:48AM +0530, Amit Kapila wrote:
> On Thu, Nov 29, 2018 at 8:46 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> With option 4 (as defined in [1]), the database ID or the user ID set to
>> 0 means that we don't apply any filter on them, which is sensible. Now,
>> we have query IDs which can be set to 0, like parseable utility
>> statements.
>
> I think we ensure that queryId won't be 0 for utility statements.
Oh, pgss_store() makes sure to enforce the query ID which has been
calculated in the post-analyze hook. That's a bit weird to be honest.
>> When a query ID is set to 0, does this mean that all query
>> IDs matching 0 are reset? Or does that mean that we don't filter out by
>> query ID?
>>
>
> It means the later one "We don't apply any filter for queryId.".
Seems like it will be possible to live happily with option 4 then.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-29 06:06:18 | Re: pg_config wrongly marked as not parallel safe? |
| Previous Message | Laurenz Albe | 2018-11-29 05:40:52 | Re: pg_config wrongly marked as not parallel safe? |