| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Minor typo |
| Date: | 2018-11-28 01:01:36 |
| Message-ID: | 20181128010136.GU1716@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 27, 2018 at 07:51:03PM -0500, Stephen Frost wrote:
> That isn't at all what I got from that.
>
> A rewrite of this really should avoid talking about removing the hole as
> if it's 'compression' because, first of all, it isn't, and second, now
> that we have *actual* compression happening, it's terribly confusing to
> talk about removing the hole using that terminology.
You may want to be careful about other comments in xloginsert.c or such
then. Removing a page hole is mentioned in a couple of places as a form
of compression if I recall correctly.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-11-28 01:02:00 | Re: MERGE SQL statement for PG12 |
| Previous Message | Sanyo Moura | 2018-11-28 01:00:39 | Re: Query with high planning time at version 11.1 compared versions 10.5 and 11.0 |