| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: typo fix |
| Date: | 2018-11-20 07:15:56 |
| Message-ID: | 20181120071556.GL4400@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 20, 2018 at 01:58:22AM -0500, Tom Lane wrote:
> The reason that's not good is that it creates a singular-plural mismatch.
> If you'd also changed "PathKeys" to "PathKey", it would still read OK,
> though I don't think it's an improvement particularly.
>
> (Hm ... though arguably, "structure" should be "structures" if we're
> going to let it stand as plural.)
Indeed, missed that. This first sentence mentions "orderings" for those
PathKeys, which refers to multiple PathKeys, so actually Amit's patch
seems to be fine, no?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haozhou Wang | 2018-11-20 07:20:27 | Re: Control your disk usage in PG: Introduction to Disk Quota Extension |
| Previous Message | Tom Lane | 2018-11-20 06:58:22 | Re: typo fix |