Re: [PATCH] XLogReadRecord returns pointer to currently read page

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: a(dot)lepikhov(at)postgrespro(dot)ru, hlinnaka(at)iki(dot)fi, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] XLogReadRecord returns pointer to currently read page
Date: 2018-11-19 04:24:34
Message-ID: 20181119042434.GD4400@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 19, 2018 at 12:28:06PM +0900, Kyotaro HORIGUCHI wrote:
> Yeah, it is incorrect in some sense, but the comment was
> suggesting the lifetime of the pointed record. So I'd like to
> have a comment like this instead.

I think that we can still live without as it is not the business of this
routine to be careful how the lifetime of a record read is handled, but
that's part of the internals of XLogReader.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-11-19 04:39:58 Re: [HACKERS] Restricting maximum keep segments by repslots
Previous Message Kyotaro HORIGUCHI 2018-11-19 04:24:08 Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS)