| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | a(dot)lepikhov(at)postgrespro(dot)ru, hlinnaka(at)iki(dot)fi, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] XLogReadRecord returns pointer to currently read page |
| Date: | 2018-11-19 01:27:29 |
| Message-ID: | 20181119012728.GA1578@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 16, 2018 at 03:23:55PM +0900, Michael Paquier wrote:
> I was looking at this patch, and shouldn't we worry about compatibility
> with plugins or utilities which look directly at what's in readRecordBuf
> for the record contents? Let's not forget that the contents of
> XLogReaderState are public.
And a couple of days later, committed. I did not notice first that the
comments of xlogreader.h mention that a couple of areas are private, and
readRecordBuf is part of that, so objection withdrawn.
There is a comment in xlog.c (on top of ReadRecord) referring to
readRecordBuf which has not been removed as part of 7fcbf6a4 when WAL
reading has been moved to its own facility. The original comment was
from 0ffe11a. So I have removed the comment at the same time.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-19 01:46:40 | Re: [HACKERS] PoC: full merge join on comparison clause |
| Previous Message | 范孝剑 (康贤) | 2018-11-19 01:26:50 | Can I skip function ResolveRecoveryConflictWithSnapshot if setting hot_standby_feedback=on all the time |