| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Adrien NAYRAT <adrien(dot)nayrat(at)anayrat(dot)info> |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: ALTER INDEX ... ALTER COLUMN not present in dump |
| Date: | 2018-11-16 13:31:03 |
| Message-ID: | 20181116133103.GA3427@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Fri, Nov 16, 2018 at 05:32:52PM +0900, Michael Paquier wrote:
> And here you go as attached. Looking closer, in v10 and older versions,
> ALTER INDEX SET STATISTICS is able to work as it is an alias of ALTER
> TABLE. The attached patch does not bother generating the ALTER INDEX
> queries for v10 and older and feeds queries with empty strings. Perhaps
> we should support that case? Or the lack of complains would be an
> argument sufficient to care only about v11 and newer versions? I would
> tend to think that supporting only v11 and above is enough. Thoughts
> are welcome.
+ appendPQExpBuffer(q, "ALTER COLUMN %s ",
+ indstatcolsarray[j])
This forgot a wrapping with fmtId(). Friday hits hard..
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| dump-alter-index-stats-v2.patch | text/x-diff | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey | 2018-11-16 14:49:35 | select (fn()).* executes function multiple times |
| Previous Message | Michael Paquier | 2018-11-16 08:32:52 | Re: ALTER INDEX ... ALTER COLUMN not present in dump |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2018-11-16 13:32:50 | Re: wal_dump output on CREATE DATABASE |
| Previous Message | Michael Paquier | 2018-11-16 12:16:04 | Re: wal_dump output on CREATE DATABASE |