Re: Removal of unnecessary CommandCounterIncrement() when doing ON COMMIT DELETE ROWS

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Removal of unnecessary CommandCounterIncrement() when doing ON COMMIT DELETE ROWS
Date: 2018-11-13 00:04:57
Message-ID: 20181113000457.GA1336@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 12, 2018 at 01:19:31PM -0300, Alvaro Herrera wrote:
> On 2018-Nov-09, Michael Paquier wrote:
>> When doing a set of ON COMMIT DELETE ROWS actions for relations, there
>> is a CCI happening after each truncation:
>
> Right, but note that this is not a loop so it's only one CCI, not one
> per relation. (This doesn't seem a big deal either way, but I see no
> reason to have that line there.)

This looks like a lack of caffeine from my side.

>> And I think that I agree with that, because visibly this applies to
>> index rebuilds but in those cases CCIs are happening locally. So I
>> think that we can get rid of that, and I suggest to remove it only on
>> HEAD only of course.
>
> +1

Thanks Álvaro for the input, I have committed the change.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-11-13 00:08:20 Re: doc fix for pg_stat_activity.backend_type
Previous Message Tom Lane 2018-11-12 23:57:19 Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation