| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: replication_slots usability issue |
| Date: | 2018-11-05 20:10:44 |
| Message-ID: | 20181105201044.ipagdwcjda5mjlmb@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018-11-02 15:51:34 +0100, Petr Jelinek wrote:
> On 01/11/2018 18:54, Andres Freund wrote:>
> >> Also, from 691d79a which you just committed:
> >> + ereport(FATAL,
> >> + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
> >> + errmsg("logical replication slots \"%s\" exists, but wal_level < logical",
> >> + NameStr(cp.slotdata.name)),
> >> I can see one grammar mistake here, as you refer to only one slot here.
> >> The error messages should read:
> >> "logical replication slot \"%s\" exists, but wal_level < logical"
> >> and:
> >> "physical replication slot \"%s\" exists, but wal_level < replica"
> >
> > Darnit. Fixed. Thanks.
> >
>
> Since we are fixing this message, shouldn't the hint for logical slot
> say "Change wal_level to be logical or higher" rather than "replica or
> higher" :)
Gah. I really wasn't firing on all cylinders here. Darned jetlag (let's
just assume that's what it was).
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2018-11-05 20:53:08 | Re: settings to control SSL/TLS protocol version |
| Previous Message | Robert Haas | 2018-11-05 20:06:41 | Re: plruby: rb_iterate symbol clash with libruby.so |