| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, obouda(at)email(dot)cz, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Wrong aggregate result when sorting by a NULL value |
| Date: | 2018-11-04 23:44:10 |
| Message-ID: | 20181104234410.f63uu33kfxy2zgjx@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2018-11-04 11:19:59 -0500, Tom Lane wrote:
> Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
> > I'm now getting a compiler warning:
>
> > execExpr.c: In function 'ExecBuildAggTrans':
> > execExpr.c:2864:7: warning: unused variable 'numInputs' [-Wunused-variable]
> > int numInputs = pertrans->numInputs;
>
> Used-for-asserts-only problem. Will fix.
Thanks. I wonder if we shouldn't turn Asserts() into something roughly
akin to if (0) {expr};. That way we'd not deal with errors about unused
variables anymore - we're not safe against unreachable code warnings
anyway.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-04 23:49:40 | Re: Wrong aggregate result when sorting by a NULL value |
| Previous Message | Tom Lane | 2018-11-04 16:19:59 | Re: Wrong aggregate result when sorting by a NULL value |