From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Ondřej Bouda <obouda(at)email(dot)cz>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: Wrong aggregate result when sorting by a NULL value |
Date: | 2018-11-03 23:08:37 |
Message-ID: | 20181103230837.6rv63tajaodxmp6j@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Hi,
On 2018-11-03 15:27:09 -0700, Andres Freund wrote:
> On 2018-11-03 18:18:40 -0400, Tom Lane wrote:
> > Andres Freund <andres(at)anarazel(dot)de> writes:
> > > And pushed. Thanks Ondřej for the report, thanks Tom & Andrew for
> > > identifying the issue.
> >
> > Hm, buildfarm seems less than pleased. Did you miss making a
> > corresponding change in the JIT code?
>
> Hm, I'm somewhat confused, let me look into that. The JIT code shouldn't
> really need to be changed here - it's the *generation* of expression
> steps that's going wrong - which then later get turned into JITed code,
> but that part worked previously for other expressions.
Turns out it's not a great idea to generate EEOP_AGG_STRICT_INPUT_CHECK
expressions with nargs = 0. Head -> Desk. Pushed a fix (+ new
assertion).
Thanks!
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-11-04 00:04:05 | Re: Unable to copy large (>2GB) files using PostgreSQL 11 (Windows) |
Previous Message | Andres Freund | 2018-11-03 22:27:09 | Re: Wrong aggregate result when sorting by a NULL value |