Re: [RFC] Removing "magic" oids

From: Andres Freund <andres(at)anarazel(dot)de>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [RFC] Removing "magic" oids
Date: 2018-10-27 18:56:56
Message-ID: 20181027185656.2jiit4epdpk46dlh@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2018-10-28 00:21:23 +0530, Amit Kapila wrote:
> On Sun, Sep 30, 2018 at 9:18 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > I think we should drop WITH OIDs support. pg_dump should convert WITH
> > OIDs tables into tables that have an explicit oid column (with an
> > appropriate default function), pg_upgrade should refuse to upgrade them.
> >
>
> Is there any technical reason why you think pg_upgrade should refuse
> to upgrade them? I think there is an argument to break backward
> compatibility here and many people on the thread seem to be okay with
> that, but refusing to upgrade sounds more restrictive.

They'd not be on-disk compatible, because the column isn't stored as a
normal column but in the t_hoff space.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alban Hertroys 2018-10-27 19:02:12 Re: Ltree: set of allowed charcters is limited to [A-Za-z0-9_]. Could the dash "-" be included?
Previous Message Amit Kapila 2018-10-27 18:51:23 Re: [RFC] Removing "magic" oids