Re: pgsql: Set pg_class.relhassubclass for partitioned indexes

On Sun, Oct 21, 2018 at 11:20:04PM -0400, Tom Lane wrote:
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> On Sun, Oct 21, 2018 at 10:59:27PM -0400, Tom Lane wrote:
>>> Seems like this commit should have touched the catalogs.sgml description
>>> for that column, as well as the pg_class.h comment for it. Neither of
>>> those are worded in a way that suggests it could be set for non-table
>>> relations.
>
>> The pg_class.h comment looked fine for me first. How would you reword
>> it?
>
> Well, the question is what "derived class" means, but I'd tend to think
> it means something that has an associated composite type; which indexes
> do not. So maybe instead of "has (or has had) derived classes", we could
> write "has (or has had) child tables or indexes"? I'm not wedded to
> particular wording for this, but I think what's there now is a bit
> misleading.

Your suggestion looks good to me.

>> relispartition tells "True if table is a partition", which is not
>> actually true as it can apply to indexes. So this should be changed in
>> v11 as well, no?
>
> Good point, that column's description is obsolete as well.

Amit, Tom, what do you think about the attached? This merges all the
things proposed.
--
Michael