Re: pgsql: Add TAP tests for pg_verify_checksums

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pgsql: Add TAP tests for pg_verify_checksums
Date: 2018-10-20 06:51:26
Message-ID: 20181020065126.GB19133@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Oct 20, 2018 at 02:03:32AM -0400, Stephen Frost wrote:
> On Sat, Oct 20, 2018 at 01:11 Andres Freund <andres(at)anarazel(dot)de> wrote:
>> or the new checksum validation logic complaining about them, and such
>>> when doing backups and I wonder if that is because people simply don’t
>>> use the two together much, making me wonder how much of an issue this
>>> really is or would be with the account-for-everything approach I’ve
>>> been advocating for.
>>
>> I mean obviously pg_verify_checksum simply hasn't been actually tested
>> much with plain postgres without extensions, given the all weaknesses
>> identified in this thread.
>
> No, it hasn’t, but pg_basebackup has been around quite a while and has
> always copied everything, as best as I can recall anyway.

At this point, let's create a new thread with a description of what has
been discussed and what we'd like to do for HEAD and v11. I got
something in mind which would result in a minimal patch. Let's start
from that.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2018-10-20 13:17:18 pgsql: Lower privilege level of programs calling regression_main
Previous Message Stephen Frost 2018-10-20 06:03:32 Re: pgsql: Add TAP tests for pg_verify_checksums

Browse pgsql-hackers by date

  From Date Subject
Next Message Stefan Kaltenbrunner 2018-10-20 14:48:57 gemulon migration upcoming
Previous Message Stephen Frost 2018-10-20 06:03:32 Re: pgsql: Add TAP tests for pg_verify_checksums