Re: Function to promote standby servers

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Function to promote standby servers
Date: 2018-10-20 04:48:56
Message-ID: 20181020044856.GE2553@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Oct 20, 2018 at 06:24:28AM +0200, Laurenz Albe wrote:
> Here is another version, with a fix in pg_proc.dat, an improved comment
> and "wait_seconds" exercised in the regression test.

Thanks for the new version. This looks pretty good to me. I'll see if
I can review it once and then commit.

> - WAIT_EVENT_SYNC_REP
> + WAIT_EVENT_SYNC_REP,
> + WAIT_EVENT_PROMOTE
> } WaitEventIPC;

Those are kept in alphabetical order. Individual wait events are also
documented with a description.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2018-10-20 04:51:11 Re: Making all nbtree entries unique by having heap TIDs participate in comparisons
Previous Message Michael Paquier 2018-10-20 04:42:48 Re: pgsql: Add TAP tests for pg_verify_checksums