| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrey <parihaaraka(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: NOTIFY does not work as expected |
| Date: | 2018-10-19 23:14:35 |
| Message-ID: | 20181019231435.ovm5jd7zwpj3zs3a@alap3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi,
On 2018-10-19 13:45:42 -0700, Andres Freund wrote:
> On 2018-10-19 13:36:31 -0400, Tom Lane wrote:
> > If we're willing to accept a ProcDie interrupt during secure_read at all,
> > I don't see why not to do it even if we got some data. We'll accept the
> > interrupt anyway the next time something happens to do
> > CHECK_FOR_INTERRUPTS; and it's unlikely that that would not be till after
> > we'd completed the query, so the net effect is just going to be that we
> > waste some cycles first.
>
> I don't immediately see a problem with changing this for reads.
One argument against changing it, although not a very strong one, is
that processing a proc die even when non-blocking prevents us from
processing commands like a client's X/terminate even if we already have
the necessary input.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2018-10-19 23:20:10 | BUG #15446: Crash on ALTER TABLE |
| Previous Message | Keith Fiske | 2018-10-19 21:04:18 | FreeBSD 11 compiling from source cannot find readline headers |