Re: pgsql: Add TAP tests for pg_verify_checksums

Hi,

On 2018-10-19 17:32:58 -0400, Stephen Frost wrote:
> As you pointed out previously, the current code *doesn't* work, before
> or after this change, and we clearly need to rework this to move things
> into libpgcommon and also fix pg_basebackup. Reverting this would at
> least get us back to having similar code between this and pg_basebackup,
> and then it'll be cleaner and clearer to have one patch which moves that
> similar logic into libpgcommon and fixes the missing exceptions for the
> EXEC_BACKEND case.
>
> Keeping the patch doesn't do anything for the pg_basebackup case, and
> confuses the issue by having these filename-pattern-whitelists which
> weren't there before and that should be removed, imv.

The current state has pg_verify_checksum work on windows for casual
usage, which includes the regression tests that previously were broken.
Whereas reverting it has the advantage that a fixup diff would be a few
lines smaller. If you want to push a revert together with a fix, be my
guest, but until that time it seems unhelpful to revert.

Greetings,

Andres Freund