Re: pgsql: Add TAP tests for pg_verify_checksums

From: Andres Freund <andres(at)anarazel(dot)de>
To: J Chapman Flack <jflack(at)math(dot)purdue(dot)edu>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: pgsql: Add TAP tests for pg_verify_checksums
Date: 2018-10-19 18:21:27
Message-ID: 20181019182127.fky4tsyugz354swu@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2018-10-19 14:08:19 -0400, J Chapman Flack wrote:
> On 10/19/2018 01:17 PM, Andres Freund wrote:
> > On 2018-10-19 10:36:59 -0400, Stephen Frost wrote:
> >
> >> I also categorically disagree with the notion that it's ok for
> >> extensions to dump files into our tablespace diretories ....
> >
> > I'm unconvinced. There already are extensions doing so, and it's not
> > like we've given them any sort of reasonable alternative. You can't just
> > create relations in a "registered" / "supported" kinda way right now, so
> > uh, yea, extension gotta make do. And that has worked for many years.
>
> For some of us following along at home, this got interesting right here.
> Could someone elaborate on what extensions do this, for what purpose?
> And what would it mean to create relations in a "registered" /
> "supported" kinda way? Has that been the topic of a past discussion
> I could catch up with?

An fdw, like cstore, might be doing it, to store data, for example. The
registered / supported thing would be to have a catalog representation
of on-disk files that is represented in the catalogs somewhow. Right now
you can't really do that because you need a proper relation (table,
index, ...) to get a relfilenode.

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-10-19 18:30:50 Re: pgsql: Add TAP tests for pg_verify_checksums
Previous Message Stephen Frost 2018-10-19 18:11:03 Re: pgsql: Add TAP tests for pg_verify_checksums

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-10-19 18:30:50 Re: pgsql: Add TAP tests for pg_verify_checksums
Previous Message Stephen Frost 2018-10-19 18:11:03 Re: pgsql: Add TAP tests for pg_verify_checksums