From: | Karsten Hilbert <Karsten(dot)Hilbert(at)gmx(dot)net> |
---|---|
To: | psycopg(at)lists(dot)postgresql(dot)org, psycopg(at)postgresql(dot)org |
Subject: | Re: Feature branches merged to master for 2.8 release |
Date: | 2018-10-15 12:11:55 |
Message-ID: | 20181015121154.GC2008@hermes.hilbert.loc |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | psycopg |
On Mon, Oct 15, 2018 at 12:48:04PM +0100, Daniele Varrazzo wrote:
> - the new 'errors' module. About it I have a doubt: we convert
> postgres error messages [2] from lower_case to CamelCase because the
> latter is the convention for Python class, but maybe leaving as they
> are makes more sense? Easier to google for them or grep for them in
> the postgres sources maybe?
Since there is no Right or Wrong here, the "best" option
might be to offer both:
Raise whatever is Right for Python (that is, CamelCase)
raise PostgresSpecificError
but support catching lower case, too:
class postgres_specific_error(PostgresSpecificError):
pass
try:
something()
except postgres_specific_error:
print('lower case')
For the lower case one I would exactly copy what's used by
PostgreSQL itself.
Make sense ?
Karsten
--
GPG 40BE 5B0E C98E 1713 AFA6 5BC0 3BEA AC80 7D4F C89B
From | Date | Subject | |
---|---|---|---|
Next Message | Federico Di Gregorio | 2018-10-15 12:26:32 | Re: Feature branches merged to master for 2.8 release |
Previous Message | Daniele Varrazzo | 2018-10-15 12:09:13 | Re: Feature branches merged to master for 2.8 release |