Re: Maximum password length

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Maximum password length
Date: 2018-10-12 20:51:49
Message-ID: 20181012205148.GT4184@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Bossart, Nathan (bossartn(at)amazon(dot)com) wrote:
> I've attached 2 patches in an effort to clarify the upper bounds on
> password lengths:
> - 0001 refactors the hard-coded 100 character buffer size used for
> password prompts for client utilities into a
> PROMPT_MAX_PASSWORD_LENGTH macro in postgres_fe.h.
> - 0002 is an attempt at documenting the password length
> restrictions and suggested workarounds for longer passwords.

If we're going to do work in this area, why wouldn't we have the client
tools and the server agree on the max length and then have them all be
consistent..?

Seems odd to decide that 100 character buffer size in the clients makes
sense and then make the server support an 8k password.

I'm also trying to figure out why it makes sense to support an 8k
password and if we've really tried seeing what happens if pg_authid gets
a toast table that's actually used for passwords...

I'll note your patches neglected to include any tests...

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-10-12 21:02:04 FULL JOIN planner deficiency
Previous Message Bossart, Nathan 2018-10-12 20:33:22 Maximum password length