Re: AllocSetContextCreate changes breake extensions

From: Christoph Berg <myon(at)debian(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: AllocSetContextCreate changes breake extensions
Date: 2018-10-12 17:10:41
Message-ID: 20181012171040.GA25709@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Re: Andres Freund 2018-10-12 <20181012170355(dot)bhxi273skjt6sag4(at)alap3(dot)anarazel(dot)de>
> Hi,
>
> Christoph Berg, on IRC, raised the issue that at least one extension
> failed compiling in v11. The extension currently does:
> https://github.com/pgq/pgq/blob/master/triggers/common.c#L225

Others have already been fixed, e.g. hll:

https://github.com/citusdata/postgresql-hll/pull/52/commits/e7bfbc80bbaca547167d645be11db24c8922385f

Andres' idea would enable the old code to continue to work, but
couldn't we additionally to backpatch the ALLOCSET_*_SIZES macros, so
the new code works also on old versions that didn't get the new
AllocSetContextCreate macro?

Christoph

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-10-12 17:20:16 Re: AllocSetContextCreate changes breake extensions
Previous Message Andres Freund 2018-10-12 17:03:55 AllocSetContextCreate changes breake extensions