| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Date: | 2018-10-12 06:05:43 |
| Message-ID: | 20181012060543.GE30064@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Oct 12, 2018 at 12:11:58PM +0900, Michael Paquier wrote:
> Agreed. I am just working on a patch for v11- which uses a
> whitelist-based method instead of what is present now. Reverting the
> tests to put the buildfarm to green could be done, but that's not the
> root of the problem.
So, I have coded this thing, and finish with the attached. The
following file patterns are accepted for the checksums:
<digits>.<segment>
<digits>_<forkname>
<digits>_<forkname>.<segment>
I have added some tests on the way to make sure that all the patterns
get covered. Please note that this skips the temporary files.
Thoughts?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| checksum-whitelist.patch | text/x-diff | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2018-10-12 10:14:48 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Previous Message | Michael Paquier | 2018-10-12 03:11:58 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ideriha, Takeshi | 2018-10-12 06:19:12 | Number of buckets/partitions of dshash |
| Previous Message | Pavel Stehule | 2018-10-12 05:51:50 | Re: [HACKERS] [PATCH] Generic type subscripting |