| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Date: | 2018-10-12 01:39:18 |
| Message-ID: | 20181012013918.GA30064@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Oct 11, 2018 at 06:04:11PM -0700, Andres Freund wrote:
> culicidae tests EXEC_BACKEND, so there's an explanation as to why it
> sometimes behaves differently. But here I don't immediately see how
> that'd matter. Probably still worth verifying that it's not somehow
> caused by that.
Thanks, that's the point of detail I needed about culicidae (you will
need to explain me one day face-to-face how you pronounce it). I have
been able to reproduce the problem, and that's a bug within
pg_verify_checksums as it fails to consider that config_exec_params is
not a file it should scan when using EXEC_BACKEND. The same can happen
with config_exec_params.new.
The attached, which fixes the issue for me, needs to be back-patched to
v11.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| checksum-exec-backend.patch | text/x-diff | 472 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-10-12 01:53:19 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Previous Message | Andres Freund | 2018-10-12 01:04:11 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-10-12 01:53:19 | Re: pgsql: Add TAP tests for pg_verify_checksums |
| Previous Message | Andres Freund | 2018-10-12 01:04:11 | Re: pgsql: Add TAP tests for pg_verify_checksums |